prosgarz35 commented on PR #3201:
URL: https://github.com/apache/james-project/pull/3201#issuecomment-5809834291
> I am not opposed to this change.
>
> Please note that this is an issue if
>
> * versionning is enabled: overwritte causes new versions to be allocated
upon dedup
> * s3 implementation is not consistent and serves halth written blobs
> * you operate the s3 your self and are write bound, or billed on writes.
Thanks for the feedback and pointers, @chibenwa!
1. Fixed the test assertion to use a static import as requested.
2. Updated the documentation (`blobstore.adoc`) and sample
`blob.properties` files across all apps to reflect `Defaults to true`.
Regarding the points mentioned: those are indeed very valid
considerations, especially avoiding unnecessary version allocation on S3
buckets with versioning enabled and sparing redundant writes when write-bound
or billed on PUT
operations. Defaulting `ifNoneMatch` to `true` protects against these
side-effects while keeping the flag configurable for setups that need to opt
out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
