prosgarz35 commented on PR #3198:
URL: https://github.com/apache/james-project/pull/3198#issuecomment-5825583675
Pushed a follow-up commit with final polish:
1. **Protocol normalization**: Switched command comparison from
`Locale.US` to `Locale.ROOT` for standard ASCII protocol tokens.
2. **Defensive flag clarity**: Added an explanatory comment detailing
the dual assignment of `lineHandlerInstalled` (protecting against early
concurrent callback invocation before `pushLineHandler` completes).
3. **Contract test coverage**: Added deterministic integration test
`mailboxEventAfterDoneShouldNotPushUnsolicitedResponses` verifying that mailbox
events arriving after IDLE deactivation (`DONE`) safely yield empty publisher
and
do not trigger unsolicited updates to the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
