quantranhong1999 commented on code in PR #3197:
URL: https://github.com/apache/james-project/pull/3197#discussion_r4129759411
##########
server/container/guice/blob/deduplication-gc/src/main/java/org/apache/james/modules/blobstore/BlobDeduplicationGCModule.java:
##########
@@ -70,14 +70,16 @@ protected void configure() {
@Singleton
@Provides
public BlobId.Factory generationAwareBlobIdFactory(Clock clock,
PlainBlobId.Factory delegate, GenerationAwareBlobId.Configuration
configuration) {
- String property =
System.getProperty("james.s3.minio.compatibility.mode");
- boolean compatibilityModeActivated =
Optional.ofNullable(property).map(Boolean::parseBoolean).orElse(false);
+ boolean compatibilityModeActivated =
Optional.ofNullable(System.getProperty("james.blobstore.folder.hierarchy"))
+ .or(() ->
Optional.ofNullable(System.getProperty("james.s3.minio.compatibility.mode")))
Review Comment:
Can we have a test to make sure `james.s3.minio.compatibility.mode` still
works (no breaking change for existing deployment relying on this)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
