quantranhong1999 opened a new pull request, #3241: URL: https://github.com/apache/james-project/pull/3241
`@PreDestroy` methods were only registered for objects Guice constructs or injects itself. Singletons returned by providers (`@provides` methods, provider instances or classes) were never stopped: RabbitMQ event buses, channel pools, the Cassandra session... They are now stopped by `GuiceJamesServer.stop()`, s**o a production shutdown releases them**, and **restarting servers in one JVM no longer leaks ~160 threads per restart, which lets tests reuse surefire forks better** (setup for later fasten tests work). The `SmtpGuiceProbe` and `ImapGuiceProbe` workarounds destroying their server factories by hand are removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
