> + return false; > + } > + if (response.getStatusCode() == 500) { > + byte[] content = > HttpUtils.closeClientButKeepContentStream(response); > + // Content can be null in the case of HEAD requests > + if (content != null) { > + try { > + AtmosError error = utils.parseAtmosErrorFromContent(command, > response, > + new String(content)); > + if (error.getCode() == 1040) { // The server is busy. Please > try again. > + return backoffHandler.shouldRetryRequest(command, > response); > + } > + // don't increment count before here, since backoff handler > does already > + command.incrementFailureCount(); > + } catch (HttpException e) { > + logger.warn(e, "error parsing response: %s", new > String(content));
Do we need to increment the failure count in here? Or move the increment into a `finally` block? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/285/files#r9651130