> } > sessionConnection = > SessionConnection.builder().hostAndPort(HostAndPort.fromParts(host, > socket.getPort())).loginCredentials( > loginCredentials).proxy(checkNotNull(proxyConfig, > "proxyConfig")).connectTimeout(timeout).sessionTimeout(timeout).build(); > } > > + static boolean hasValidPrivateKey(LoginCredentials loginCredentials) { > + return loginCredentials.getPrivateKey() != null && > + !loginCredentials.getPrivateKey().isEmpty() &&
Why the empty check? This is new, I guess? Previously, an empty (but non-null) private key would have been accepted by the code? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/312/files#r10856393