I think the whole authentication login with these ssh connections needs a 
rethink at some point (hopefully not with this pull request though). The way I, 
as a user, would like it to work is that I just pile on authentication methods 
that have some hope of succeeding and then when connecting we run through those 
until one succeeds or we run out of candidates.

As it currently is implemented, the connections will only try ssh-agent if 
there is no other method defined.

Also the ```isAvailable()``` logic and how it is used inside the agent proxy 
librabry is very limited currently. For example on windows that will always 
return true and this will lead to ```createConnector()``` returning a 
```PageantConnector``` regardless of whether one is actually running. Also 
there is no way of using the OpenSSH ssh-agent on windows currently. I imagine 
it would require some extra code since on unixes the communication goes over 
unix sockets with jna native integration. However these are limitations in 
jsch-agentproxy implementation. And IMO this pull request represents 
functionality that is significantly better than having no ssh-agent support.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38659488

Reply via email to