> +
> +      if (templateOptions.getCommands().isPresent()) {
> +         containerConfigBuilder.cmd(templateOptions.getCommands().get());
> +      }
> +
> +      if (templateOptions.getMemory().isPresent()) {
> +         containerConfigBuilder.memory(templateOptions.getMemory().get());
> +      }
> +
> +      if (templateOptions.getCpuShares().isPresent()) {
> +         
> containerConfigBuilder.cpuShares(templateOptions.getCpuShares().get());
> +      }
> +
> +      if (templateOptions.getVolumes().isPresent()) {
> +         Map<String, Object> volumes = Maps.newLinkedHashMap();
> +         for (String containerDir : 
> templateOptions.getVolumes().get().values()) {

This isn't right. You're throwing away the host directory portion. We have two 
use cases for volumes, one is mounting a host directory in a specific location 
on a container, the other is creating a volume in a specific location on a 
container for export to another container. This will only cover the second case.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/57/files#r14484014

Reply via email to