> IMO this is a reasonable tradeoff. OK, then let's keep as-is.
> Also I see jenkins/cloudbees failing due to checkstyle issues. Checkstyle should never cause these builds to fail red. [This one](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1434/console) looks like a compilation error? ``` Waiting for Jenkins to finish collecting data [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project openstack-nova: Compilation failure: Compilation failure: [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/functions/AllocateAndAddFloatingIpToNode.java:[36,55] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [ERROR] location: package org.jclouds.openstack.nova.v2_0.compute.options [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/functions/AllocateAndAddFloatingIpToNode.java:[55,35] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/functions/AllocateAndAddFloatingIpToNode.java:[74,63] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [JENKINS] Archiving /scratch/jenkins/workspace/jclouds-java-7-pull-requests/providers/aws-ec2/pom.xml to org.apache.jclouds.provider/aws-ec2/1.8.0-SNAPSHOT/aws-ec2-1.8.0-SNAPSHOT.pom [ERROR] location: class org.jclouds.openstack.nova.v2_0.compute.functions.AllocateAndAddFloatingIpToNode [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java:[45,55] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [ERROR] location: package org.jclouds.openstack.nova.v2_0.compute.options [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java:[157,43] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [ERROR] location: class org.jclouds.openstack.nova.v2_0.compute.strategy.ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java:[158,76] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [ERROR] location: class org.jclouds.openstack.nova.v2_0.compute.strategy.ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java:[161,42] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java:[162,22] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java:[162,82] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java:[163,49] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java:[157,118] cannot infer type arguments for <O>com.google.common.util.concurrent.ListenableFuture<O>; [ERROR] reason: no unique maximal instance exists for type variable O with upper bounds java.lang.Object [ERROR] -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project openstack-nova: Compilation failure ``` And [the other](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/963/console) was barfing because of the missing class: ``` [ERROR] /scratch/jenkins/workspace/jclouds-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java:[163,49] cannot find symbol [ERROR] symbol: class NodeAndNovaTemplateOptions [ERROR] -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project openstack-nova: Compilation failure ``` --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomment-47987218