> + public T id(String id) {
> + this.id = id;
> + return self();
> + }
> +
> + public TokenCredentials build() {
> + return new TokenCredentials(id);
> + }
> +
> + public T fromTokenCredentials(TokenCredentials in) {
> + return this
> + .id(in.getId());
> + }
> + }
> +
> + private static class ConcreteBuilder extends Builder<ConcreteBuilder> {
There is no need for the builder to be abstract if the Builder does not have
more than one subclass. I'd remove the ConcreteBuilder and use the Builder
directly, but this pattern is also used in the other existing credential types
(worth removing this unnecessary pattern there too?).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/433/files#r16746819
