> +
> +         /*
> +          * Check request
> +          */
> +         assertEquals(server.getRequestCount(), 3);
> +         assertAuthentication(server);
> +         assertRequest(server.takeRequest(), "GET", 
> "/v2.0/security-group-rules");
> +         assertRequest(server.takeRequest(), "GET", 
> "/v2.0/security-group-rules?marker=71c1e68c-171a-4aa2-aca5-50ea153a3718");
> +
> +         /*
> +          * Check response
> +          */
> +         assertNotNull(rules);
> +         assertEquals(rules.size(), 8);
> +         assertEquals(rules.get(0).getId(), 
> "3c0e45ff-adaf-4124-b083-bf390e5482ff");
> +         assertEquals(rules.get(7).getId(), 
> "f7d45c89-008e-4bab-88ad-d6811724c51c2");

> In this case this tests that paging was successful.

Again, probably didn't express myself clearly here ;-) It looks like we are 
testing not just that the size of the collection is as expected, but that the 
order (well, we only test the first and last) is "as expected".

Are these intended to be ordered, then? And does the order need to match the 
order in which they are represented in the response, or is there some other 
ordering criterion? A comment in the test to clarify that would help, I think 
;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r17062091

Reply via email to