> +@Singleton > +public class FirewallRuleToIpPermission implements Function<FirewallRule, > IpPermission> { > + > + private final Map<FirewallIpProtocol, IpProtocol> > firewallIpProtocolToIpProtocol; > + > + @Inject > + public FirewallRuleToIpPermission(Map<FirewallIpProtocol, IpProtocol> > firewallIpProtocolToIpProtocol) { > + this.firewallIpProtocolToIpProtocol = > checkNotNull(firewallIpProtocolToIpProtocol, > + "firewallIpProtocolToIpProtocol"); > + } > + > + @Override > + public IpPermission apply(FirewallRule input) { > + IpPermission.Builder permissionBuilder = new IpPermission.Builder(); > + String destinationPort = input.getDestinationPort(); > + if (destinationPort != null) {
Add a comment with some examples of valid input/output, so the reader has a better idea of what this code is trying to do..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/70/files#r17825947