[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167004#comment-14167004 ]
Adrian Cole commented on JCLOUDS-750: ------------------------------------- [~andreaturli] I think Adam's old builder thing is of a by-gone era. Offline generators don't keep up with changes to mainline code (ie round-tripping). Also, we wouldn't get to leverage a tool written by others, including is automated tests, documentation, etc. That said, auto-value doesn't cover cases like Builders (which there may be a few cases where we'd still want), or gson, JAXB (maybe? dunno actually as not tried). We can probably learn from adam's codebase, which was written before auto-value and helped between then and now. Personally, I'd rather kill the Builders than maintain my own generator or write by hand. > Replace hand-written domain classes with Auto-Value ones > -------------------------------------------------------- > > Key: JCLOUDS-750 > URL: https://issues.apache.org/jira/browse/JCLOUDS-750 > Project: jclouds > Issue Type: New Feature > Reporter: Adrian Cole > > In doing maintenance and ports, I've noticed that we have drift related to > using guava to implement hashCode/equals on domain classes. Having an > opportunity for a guava incompatibility on something like this is not high > value, in my opinion. Moreover, we have a lot of other inconsistency in our > value classes, which have caused bugs, and extra review time on pull requests. > Auto-Value generates concrete implementations and takes out the possibility > of inconsistency of field names, Nullability, etc. It is handled at compile > time, so doesn't introduce a dependency of note, nor a chance of guava > version conflict for our users. > https://github.com/google/auto/tree/master/value > While it may be the case that we need custom gson adapters (ex opposed to the > ConstructorAnnotation approach), or a revision to our approach, I believe > that this work is worthwhile. > While it is the case that our Builders won't be generated, I still think this > is valuable. For example, in many cases, we shouldn't be making Builders > anyway (ex. they are read-only objects never instantiated, such as lists). > Even if we choose to still write Builders, the problem is isolated there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)