> @@ -121,6 +125,6 @@ protected static int getLoginPort(Container container) {
> }
> }
> }
> - throw new IllegalStateException("Cannot determine the login port for "
> + container.getId());
> + return -1;
Nope, it looks like the ripple effect of changes is too big, particularly since
its only Docker that can ever have an image (container) that you cannot log
into. I think it's safer to leave the magic value here, but perhaps document
the Docker class explaining what it means?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89/files#r18727590
