> @@ -445,8 +355,66 @@ public void suspendNode(String id) { > api.getVirtualGuestApi().pauseVirtualGuest(Long.parseLong(id)); > } > > - private boolean isOperatingSystem(SoftwareDescription input) { > - return input.getOperatingSystem() == 1; > + /** > + * This method will deliberately skip device position 1 as it is reserved > to SWAP > + * @param blockDeviceCapacities list of blockDevices to be attached > + * @param diskType disks can be LOCAL or SAN > + * @return > + */ > + private List<VirtualGuestBlockDevice> getBlockDevices(List<Integer> > blockDeviceCapacities, String diskType) { > + List<VirtualGuestBlockDevice> blockDevices = Lists.newArrayList();
[minor] Does the result need to me a mutable list? If not, use `ImmutableList.builder()`? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/568/files#r18748117