Hi @adriancole ! I'm glad that you managed to give this PR a code review.

On my first <a 
href="https://github.com/devcsrj/jclouds-labs/commit/1c8fd5cea04e9562ca83b5354b61b0aac47ead87#diff-599cc9aa50e03fc73e98485f705e2575R71";>commit</a>,
 I was using <a 
href="https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/rest/annotations/XMLResponseParser.java";>@XMLResponseParser</a>.
 Really painful since ProfitBricks APIs are using SOAP (has extra header 
elements and stuff). It was then <a 
href="https://github.com/jclouds/jclouds-labs/pull/72#issuecomment-55385403";>noted</a>
 by nacx that jclouds supports <code>@JAXBResponseParser</code>. Since the 
domain classes generated from java's <i>wsimport</i> of <a 
href="https://api.profitbricks.com/1.3/wsdl";>PB's WSDL</a> already had JAXB 
annotations, I figured it's easier to make use of those as well. Talk about bad 
judgement call. Haha

Anyway, I'll see what I can do. Thanks for the review! :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/72#issuecomment-61210128

Reply via email to