Now, we can safely use bearer tokens or "none" alg without guice crapping out. 
I also refactored naming of things.

As always in this api, there's more shoveling to do, but this is certainly a 
step forwards cognitively and also from a tech debt pov.

replaces #87
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds-labs-google 
adrian.massive-oauth-cleanup

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/90

-- Commit Summary --

  * Refactor OAuth so that it doesn't require private keys when we aren't 
signing anything.

-- File Changes --

    M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApiMetadata.java
 (4)
    M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/internal/BaseGoogleCloudStorageExpectTest.java
 (15)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineApiMetadata.java
 (4)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineProperties.java
 (2)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/internal/BaseGoogleComputeEngineApiMockTest.java
 (3)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/internal/BaseGoogleComputeEngineExpectTest.java
 (6)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/internal/GoogleComputeEngineTestModule.java
 (6)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/internal/TestProperties.java
 (13)
    M oauth/README (6)
    M oauth/pom.xml (4)
    A oauth/src/main/java/org/jclouds/oauth/v2/JWSAlgorithms.java (75)
    M oauth/src/main/java/org/jclouds/oauth/v2/OAuthApi.java (8)
    M oauth/src/main/java/org/jclouds/oauth/v2/OAuthApiMetadata.java (8)
    D oauth/src/main/java/org/jclouds/oauth/v2/OAuthConstants.java (78)
    R oauth/src/main/java/org/jclouds/oauth/v2/binders/TokenBinder.java (9)
    M oauth/src/main/java/org/jclouds/oauth/v2/config/CredentialType.java (20)
    R oauth/src/main/java/org/jclouds/oauth/v2/config/OAuth.java (6)
    M 
oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthAuthenticationModule.java 
(10)
    M oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthHttpApiModule.java 
(2)
    M oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthModule.java (45)
    M oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthProperties.java (18)
    M oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthScopes.java (3)
    M oauth/src/main/java/org/jclouds/oauth/v2/domain/Header.java (2)
    D oauth/src/main/java/org/jclouds/oauth/v2/domain/OAuthCredentials.java 
(129)
    M 
oauth/src/main/java/org/jclouds/oauth/v2/filters/BearerTokenAuthenticator.java 
(7)
    M oauth/src/main/java/org/jclouds/oauth/v2/filters/OAuthAuthenticator.java 
(15)
    M oauth/src/main/java/org/jclouds/oauth/v2/functions/BuildTokenRequest.java 
(92)
    D 
oauth/src/main/java/org/jclouds/oauth/v2/functions/OAuthCredentialsSupplier.java
 (130)
    A 
oauth/src/main/java/org/jclouds/oauth/v2/functions/PrivateKeySupplier.java (105)
    M 
oauth/src/main/java/org/jclouds/oauth/v2/functions/SignOrProduceMacForToken.java
 (59)
    M oauth/src/test/java/org/jclouds/oauth/v2/OAuthApiMetadataTest.java (5)
    M oauth/src/test/java/org/jclouds/oauth/v2/OAuthTestUtils.java (7)
    R oauth/src/test/java/org/jclouds/oauth/v2/binders/TokenBinderTest.java (7)
    M oauth/src/test/java/org/jclouds/oauth/v2/features/OAuthApiLiveTest.java 
(17)
    D 
oauth/src/test/java/org/jclouds/oauth/v2/functions/OAuthCredentialsFromPKTest.java
 (62)
    D 
oauth/src/test/java/org/jclouds/oauth/v2/functions/OAuthCredentialsSupplierTest.java
 (56)
    A 
oauth/src/test/java/org/jclouds/oauth/v2/functions/PrivateKeySupplierTest.java 
(83)
    M 
oauth/src/test/java/org/jclouds/oauth/v2/functions/SignerFunctionTest.java (9)
    M 
oauth/src/test/java/org/jclouds/oauth/v2/handlers/OAuthErrorHandlerTest.java 
(16)
    M 
oauth/src/test/java/org/jclouds/oauth/v2/internal/BaseOAuthApiLiveTest.java (7)
    M 
oauth/src/test/java/org/jclouds/oauth/v2/internal/BaseOAuthAuthenticatedApiLiveTest.java
 (14)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/90.patch
https://github.com/jclouds/jclouds-labs-google/pull/90.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/90

Reply via email to