>           })
>           protected ServerInternalWithoutImage(String id, @Nullable String 
> name, java.util.Set<Link> links, @Nullable String uuid, String tenantId,
> -                                  String userId, Date updated, Date created, 
> @Nullable String hostId, @Nullable String accessIPv4,
> -                                  @Nullable String accessIPv6, Server.Status 
> status, Resource flavor, @Nullable String keyName,
> -                                  @Nullable String configDrive, 
> Multimap<String, Address> addresses, Map<String, String> metadata,
> -                                  @Nullable ServerExtendedStatus 
> extendedStatus, @Nullable ServerExtendedAttributes extendedAttributes, 
> @Nullable String diskConfig) {
> +                                              String userId, Date updated, 
> Date created, @Nullable String hostId, @Nullable String accessIPv4,
> +                                              @Nullable String accessIPv6, 
> Server.Status status, Resource flavor, @Nullable String keyName,
> +                                              @Nullable String configDrive, 
> Multimap<String, Address> addresses, Map<String, String> metadata,
> +                                              @Nullable ServerExtendedStatus 
> extendedStatus, @Nullable ServerExtendedAttributes extendedAttributes, 
> @Nullable String diskConfig) {

I can clean up almost all of this with autoformat, but the 
`ServerInternalWithoutImage()` layout is apparently special. If you look at the 
original version, there are two different styles of indentation. 
[One](https://github.com/jclouds/jclouds/blob/1.8.x/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/config/NovaParserModule.java#L154)
 is like mine and the 
[other](https://github.com/jclouds/jclouds/blob/1.8.x/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/config/NovaParserModule.java#L167)
 isn't. Seeing as autoformat matched one and not the other, I'm inclined to 
think that one indentation style wasn't intentional.

Do you know which one was intended? Or are you concerned more with isolating 
changes for this commit?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626/files#r21994966

Reply via email to