@devcsrj I've added the comments. The code looks very good, and you've followed the advice of other PRs. Many thanks for that! :) This way we can set a good base line so upcoming PRs are easier to review and to get merged.
Apart from the inline comments, there are a couple things missing that should be added to this (already good) pull request: * Add Mock tests for every method in the DataCenterApi. These tests are the unit tests that allow us to test that the API behaves as expected without connecting to the real cloud service. * Add unit tests for the other classes: The SOAP filter, the binders, the response parsers and the custom predicates. They should be pretty straight forward and in most cases you should be able to just call the methods with custom values. If you need to mock objects, we use EasyMock. Ping us if you need help. Good job! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/72#issuecomment-67710587
