This PR refactors the filesystem blobstore tests slightly for Mac OS.

- Utilizes class/method level `dataProvider` and `dataProviderClass` in tests 
where necessary
- (minor) 3-space indent cleanup

`org.jclouds.util.TestUtils`
- pulled up constants from `org.jclouds.filesystem.utils.TestUtils`
- pulled up `@DataProvider` for Mac OS/Windows
- pulled up `isWindowsOs()` method

`org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest`
- pulled up description of Mac OS xattrs bug info to class level
- added failing methods from `BaseBlobIntegrationTest`
- now skips all tests on Mac OS

@zack-shoylev Can you please run this on Windows for a sanity check? Thx!
You can merge this Pull Request by running:

  git pull https://github.com/rackspace/jclouds refactor/filesystem-tests-osx

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/643

-- Commit Summary --

  * Refactor blobstore filesystem tests for Mac OS X

-- File Changes --

    M 
apis/filesystem/src/test/java/org/jclouds/filesystem/FilesystemBlobStoreTest.java
 (14)
    M 
apis/filesystem/src/test/java/org/jclouds/filesystem/integration/FilesystemBlobIntegrationTest.java
 (66)
    M 
apis/filesystem/src/test/java/org/jclouds/filesystem/integration/FilesystemContainerIntegrationTest.java
 (17)
    M 
apis/filesystem/src/test/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImplTest.java
 (18)
    M apis/filesystem/src/test/java/org/jclouds/filesystem/utils/TestUtils.java 
(356)
    M core/src/test/java/org/jclouds/utils/TestUtils.java (30)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/643.patch
https://github.com/jclouds/jclouds/pull/643.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/643

Reply via email to