> +      checkNotNull(from, "Null image");
> +
> +      String desc = from.name();
> +      OsFamily osFamily = parseOsFamily(desc);
> +
> +      OperatingSystem os = OperatingSystem.builder()
> +           .description(osFamily.value())
> +           .family(osFamily)
> +           .version(parseVersion(desc))
> +           .is64Bit(is64Bit(desc))
> +           .build();
> +
> +      return new ImageBuilder()
> +           .ids(from.id())
> +           .name(desc)
> +           .location(mapLocation(from.location()))

Hmm. I couldn't tell if it it qualifies to the __available in all regions__ 
statement. Let me describe it instead.

So given is an image called `Ubuntu-14.04-LTS-server-2015-03-01`. This exists 
in 
[Location](https://github.com/jclouds/jclouds-labs/pull/145/files#diff-8dba16965654b3b80ba6cc57f45b8278L19)s:
 `de/fra`, `de/fkb` but with different `id`s. There's also a _similar_ image 
called `Ubuntu-14.04-LTS-server-2015-03-02` in `us/las` and `us/lasdev` also 
different IDs. Does this qualify to the statement? (Does this present an issue?)

Also, I thought of `LocationScope` as a hierarchy. So `Provider` -> `Region` -> 
`Zone`, etc., and so I mapped it like `Location`(=`Provider`) -> 
`DataCenter`(`=Region`). Correct me if I assumed incorrectly

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/145/files#r25748163

Reply via email to