This is probably also the root cause of JCLOUDS-657 (unconfirmed)

InstanceToNodeMetadata filters out firewall tags added to instances. This is 
causing BaseComputeService#listNodes to fail when it attempts to list nodes 
like j-t2. When constructing a `Predicate<String> isFirewallTag` 
DnsNameValidator is called and an IllegalArgumentException is thrown. 

Possible solutions:
 - We could remove the functionality for filtering out firewall tags now that 
there is only one firewall tag added to each instance instead of one per 
inbound port. 
 - We could add a try/catch block and ignore the IllegalArgumentException. 

I lean toward the first option of removing functionality for filtering out tags 
added by jclouds. 
@nacx  WDYT?
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs-google/pull/139

-- Commit Summary --

  * fix to InstanceToNodeMetadata

-- File Changes --

    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/FirewallTagNamingConvention.java
 (3)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/InstanceToNodeMetadata.java
 (16)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/139.patch
https://github.com/jclouds/jclouds-labs-google/pull/139.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/139

Reply via email to