>     protected Client(X509Certificate certificate, String orgname, String 
> clientname, String name, boolean validator,
> -         @Nullable PrivateKey privateKey) {
> +         @Nullable PrivateKey privateKey, PublicKey publicKey) {

If the public key is not returned in Chef Server versions < 12 it should be 
marked as nullable. Otherwise the deserialization of an object missing the 
public key will fail.

If this is the case, then could you add a test to verify this? In the test 
class you updated, keep a test for a client without the public key and one for 
a client that has it set.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/828/files#r35579803

Reply via email to