> +   }
> +
> +   public static Properties defaultProperties() {
> +      Properties properties = BaseHttpApiMetadata.defaultProperties();
> +      return properties;
> +   }
> +
> +   public static class Builder extends BaseHttpApiMetadata.Builder<EtcdApi, 
> Builder> {
> +
> +      protected Builder() {
> +         super(EtcdApi.class);
> +         id("etcd").
> +         name("Etcd API").
> +         identityName("username:password").
> +         defaultIdentity("Optional Username").
> +         defaultCredential("Optional Password").

The defaults are ok. The `identityName` property describes the identity (a 
username, an email, a token), and the `credentialName` describes the credential 
(a password, a private key, etc), so users know what to put there.
Once there is auth in this provider, the description of the identity would me 
misleading as it would encourage users to use the form "username:password" in 
the identity field. What about the credential field?
The defaults values are OK; it's just a matter about properly describing how 
the authentication is expected to be provided.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/195/files#r36187855

Reply via email to