The `GoogleComputeEngineServiceLiveTest#testListSizes` live test has started failing recently. I've observed that the API is no longer returning the [scratchDisks](https://github.com/jclouds/jclouds/blob/master/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/MachineType.java#L64) used to build the [hardware profile volumes](https://github.com/jclouds/jclouds/blob/master/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/MachineTypeToHardware.java#L72-L82), causing the test to fail [here](https://github.com/jclouds/jclouds/blob/master/compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java#L847).
Given that it is ok that in GCE the MachineType might not contain scratch disks, there are several ways to address this, including: * Just override the test and remove the disks size assertion. * If the MachineType has no scratch disks, add a *dummy* volume (note that its size is nullable), just to mark that at instance creation time a disk [will be created by default](https://github.com/jclouds/jclouds/blob/master/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java#L125) (the one implemented in this PR). * Always add this *dummy* disk to represent the disk we create for the image. @danbroudy how do you think this should be better fixed? You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/854 -- Commit Summary -- * Take into account that hardware profiles may not have scratch disks -- File Changes -- M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/MachineTypeToHardware.java (19) -- Patch Links -- https://github.com/jclouds/jclouds/pull/854.patch https://github.com/jclouds/jclouds/pull/854.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/854
