> +      assertEquals(image.id(), testImageId);
> +      assertEquals(image.properties().name(), 
> "ubuntu-14.04.3-server-amd64.iso");
> +   }
> +   
> +   @Test
> +   public void testList() {
> +      List<Image> images = imageApi().getList();
> +
> +      assertNotNull(images);
> +      assertFalse(images.isEmpty());
> +      assertTrue(images.size() > 1);
> +   }
> +   
> +   private ImageApi imageApi() {
> +      return api.imageApi();
> +   }

That makes sense

Jasmin Gacić
On Feb 29, 2016 13:36, "Reijhanniel Jearl Campos" <[email protected]>
wrote:

> In
> profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/ImageApiLiveTest.java
> <https://github.com/jclouds/jclouds-labs/pull/242#discussion_r54403984>:
>
> > +      assertEquals(image.id(), testImageId);
> > +      assertEquals(image.properties().name(), 
> > "ubuntu-14.04.3-server-amd64.iso");
> > +   }
> > +
> > +   @Test
> > +   public void testList() {
> > +      List<Image> images = imageApi().getList();
> > +
> > +      assertNotNull(images);
> > +      assertFalse(images.isEmpty());
> > +      assertTrue(images.size() > 1);
> > +   }
> > +
> > +   private ImageApi imageApi() {
> > +      return api.imageApi();
> > +   }
>
> He might be pertaining to methods with the DepthOptions param (getList,
> getImage). :)
>
> About the *update* and *delete* operations: Since the PB API doesn't have
> an endpoint to actually upload images (was this via FTP, IIRC?), would it
> make sense if we just remove these operations, and just leave the GET
> requests to keep it simple? This is the case for the soap counterpart
> <https://github.com/jclouds/jclouds/blob/master/providers/profitbricks/src/main/java/org/jclouds/profitbricks/features/ImageApi.java#L42>.
> Although I'm not aware as to how many users would actually depend on this
> feature, so... thoughts?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jclouds/jclouds-labs/pull/242/files#r54403984>.
>


---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/242/files#r54406011

Reply via email to