Thanks @bostko I'm going through this in more detail, and will contribute some changes that make it conform more to "the jclouds way". Here are a few pointers:
* See jclouds best practices: https://cwiki.apache.org/confluence/display/JCLOUDS/Writing+jclouds+Code * Include clear TODO/FIXME comments where you think the code is not ready (e.g. where you are using `Thread.sleep(15000)` * Never use System.exit * Never use System.out.println - always use the jclouds logger * Never use `e.printStackTrace` - always log or propagate the exception * Use Google Guice for dependency injection, to keep things decoupled and to allow users to replace parts of the implementation/config as required * Use Guice's `@Inject` to get existing jclouds utilities, such as `org.jclouds.crypto.Crypto`. * Declaring dependencies like `bcprov-jdk15on` version 1.54 is dangerous - other parts of jclouds use bouncycastle 1.49. We can replace this with use of jclouds `Crypto`. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/170#issuecomment-202755416
