https://issues.apache.org/jira/browse/JCLOUDS-1105
I'm still not sure about the impact of this change. I'd rather play a bit with this and get feedback from users. I haven't been able to test it live yet, so this PR just relies on the unit tests. I plan to do some testing later today but I'd love to get some feedback from others too. /cc @andreaturli @aledsage @andras-nemes You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/947 -- Commit Summary -- * JCLOUDS-1105: Do not create the default security group if custom groups are specified -- File Changes -- M apis/ec2/src/main/java/org/jclouds/ec2/compute/strategy/CreateKeyPairAndSecurityGroupsAsNeededAndReturnRunOptions.java (11) M apis/ec2/src/test/java/org/jclouds/ec2/compute/strategy/CreateKeyPairAndSecurityGroupsAsNeededAndReturnRunOptionsTest.java (13) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/strategy/CreateKeyPairPlacementAndSecurityGroupsAsNeededAndReturnRunOptionsTest.java (26) -- Patch Links -- https://github.com/jclouds/jclouds/pull/947.patch https://github.com/jclouds/jclouds/pull/947.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/947
