> bump We have folks who are waiting to test this in few days. Would be awesome > if we could get this merged soon since we have couple of more PRs left. Thank > you so much for all your feedback!!!
Apologies for the delay. I'm just back from ApacheCon in Vancouver and was still going through my backlog :) I think with the current comments there are many things to think about and discuss. I think it would make sense to split this into two pull requests: one with all the APIs, and one with the compute service implementation and the transformation functions. The main reason is: * APIs will be merged sooner. * Implementing the compute service will bring some design discussions onto the table (as seen). How to design user access to VMs, how to match jclouds entities to azure ones, etc. * We consider the compute service properly implemented once there is a test that extends the `BaseComputeServiceLiveTest` (have a look at the [digitalocean](https://github.com/jclouds/jclouds/blob/master/providers/digitalocean2/src/test/java/org/jclouds/digitalocean2/compute/DigitalOcean2ComputeServiceLiveTest.java) one for an example) and one that extends the `BaseTemplateBuilderLiveTest` (again, see the [digitalocean](https://github.com/jclouds/jclouds/blob/master/providers/digitalocean2/src/test/java/org/jclouds/digitalocean2/compute/DigitalOcean2TemplateBuilderLiveTest.java) one). These tests *are the contract* for the compute service and must be passing (with little and minor modifications, if you look at the examples you'll see they just add things and override just very few things) to show that the jclouds expected functionality is covered. I think splitting the PR will help you focus and also advance in other areas while the compute service is a WIP. It will also help to develop it step by step: we can perhaps merge first just the compute service (with a proper design and entity mappings) and later on merge the tests and the fixes required to the model/impl to make them pass and meet the jclouds contract. WDYT? Look forward to seeing all this stuff merged! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/267#issuecomment-220476220
