> @@ -21,6 +21,18 @@
> @AutoValue
> public class VMImage {
>
> + public VMImage(String publisher, String offer, String sku, String
> version, String location) {
Don't do this,as it is an auto-value anti-pattern. Leave the default
constructor not visible, in default scope, and provide a static factory method
to instantiate this. Also replace fields by abstract methods. This helper class
should be trated just like any other domain class. Apply this also tot he other
helper classes that do not properly implement autovalue.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/291/files/8a39037237f5cccc7d100bc58a9a82bdb89924b1#r67885733
