For review only 
@nacx I'd appreciate if you could have a look at it

Still something wrong
```

java.lang.AssertionError: expected [[user=foo, passwordPresent=true, 
privateKeyPresent=false, shouldAuthenticateSudo=true]] but found 
[[user=jclouds, passwordPresent=true, privateKeyPresent=false, 
shouldAuthenticateSudo=true]]
Expected :[user=foo, passwordPresent=true, privateKeyPresent=false, 
shouldAuthenticateSudo=true]
Actual   :[user=jclouds, passwordPresent=true, privateKeyPresent=false, 
shouldAuthenticateSudo=true]
 <Click to see difference>


        at org.testng.Assert.fail(Assert.java:94)
        at org.testng.Assert.failNotEquals(Assert.java:494)
        at org.testng.Assert.assertEquals(Assert.java:123)
        at org.testng.Assert.assertEquals(Assert.java:165)
        at 
org.jclouds.compute.internal.BaseTemplateBuilderLiveTest.tryOverrideUsingPropertyKey(BaseTemplateBuilderLiveTest.java:213)
        at 
org.jclouds.compute.internal.BaseTemplateBuilderLiveTest.testTemplateBuilderWithLoginUserSpecified(BaseTemplateBuilderLiveTest.java:189)

```
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/323

-- Commit Summary --

  * wip

-- File Changes --

    M azurecompute-arm/pom.xml (7)
    M 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/AzureComputeProviderMetadata.java
 (41)
    M 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/AzureComputeServiceAdapter.java
 (36)
    M 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/config/AzureComputeServiceContextModule.java
 (16)
    M 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/functions/DeploymentToNodeMetadata.java
 (35)
    M 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/functions/VMImageToImage.java
 (30)
    D 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/strategy/AzurePopulateDefaultLoginCredentialsForImageStrategy.java
 (43)
    M 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/util/DeploymentTemplateBuilder.java
 (60)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/323.patch
https://github.com/jclouds/jclouds-labs/pull/323.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/323

Reply via email to