Updates made.

I was able to switch to using `@SinceApiVersion`, very pleased with that.   The 
[key 
thing](https://github.com/jclouds/jclouds/pull/1102/commits/3bff59d28c5260e18504c6570ad5cb47117a3d48#diff-7d8365e45e83df7988b1084146439d71R158)
 is that I needed to change the override from  a just-override-it approach to 
one that will allow the annotation to _upgrade_ the version as compared to 
`apiVersion` but not _downgrade_ it, which is much safer.  All the unit tests 
now pass, and my live subnet test too.

By the way how is the `@ApiVersion` actually injected in places like 
[FormSigner](https://github.com/jclouds/jclouds/blob/master/apis/sts/src/main/java/org/jclouds/aws/filters/FormSignerV4.java#L96),
 for example?  I think the value is being taken from 
[AWSEC2ApiMetadata](https://github.com/jclouds/jclouds/blob/master/providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/AWSEC2ApiMetadata.java#L62)
 but I couldn't work out how jclouds configures Guice (or whatever) to actually 
wire them together.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1102#issuecomment-302513209

Reply via email to