nacx commented on this pull request.
> - @Nullable - public abstract List<AbstractDrive> deviceOrDisks(); Oh, I see now that inheritance here was there not only to reuse fields but because the API returns collections with different object types in it. To avoid having a `List<Object>`, which makes the API hard to consume, would it make sense to have just one object with all fields? I see the child classes just had one or two different fields. Would that make sense? If not, I'd consider getting the abstract classes back and just be extra-careful in variable order. take into account that the fields in the base class are serialized first, then the ones in the child class (and if at some point the base class is modified, the annotations in all child classes need to be updated accordingly). Apologies for the noise if you consider the second option to be better, but till now it wasn't clear for me the purpose of the abstract classes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/434#pullrequestreview-113545506
