andreaturli requested changes on this pull request.

thanks @axel3rd it is super useful!

I've left some comments mainly on the snippets: please address them and edit 
the document accordingly, i.e.  if you replace `Some.class` with 
`NovaApi.class` make sure you do it all over the places.

Thanks

> @@ -92,6 +93,131 @@ There are some differences in terminology between jclouds 
> and OpenStack that sho
   </div>
 </div>
 
+## <a id="keystone"></a>Keystone v2-v3 authentication
+
+Openstack Keystone (aka: [OpenStack Identity 
Service](https://docs.openstack.org/keystone/latest/)) has major changes 
between v2 and v3 (detail. [Identity API v2.0 and v3 
History](https://docs.openstack.org/keystone/latest/contributor/http-api.html)).
+
+Basically to login, you should provide:
+
+* On v2: *tenant*, *user*, *password*.
+* On v3: a *project* (new name for *tenant*), an authentication *domain* for 
this *project*, a *user*, an authentication *domain* for this *user* (the two 
domains can be different).
+
+JClouds provide backward compatibility between keystone v2-v3 ... but you 
should have following section in mind to fully understand the authentication on 
your Openstack platform (in addition of blog: [OpenStack Keystone V3 
Support](https://jclouds.apache.org/blog/2018/01/16/keystone-v3/)).

please use `jclouds` or `Apache jclouds`

> @@ -92,6 +93,131 @@ There are some differences in terminology between jclouds 
> and OpenStack that sho
   </div>
 </div>
 
+## <a id="keystone"></a>Keystone v2-v3 authentication
+
+Openstack Keystone (aka: [OpenStack Identity 
Service](https://docs.openstack.org/keystone/latest/)) has major changes 
between v2 and v3 (detail. [Identity API v2.0 and v3 
History](https://docs.openstack.org/keystone/latest/contributor/http-api.html)).
+
+Basically to login, you should provide:
+
+* On v2: *tenant*, *user*, *password*.
+* On v3: a *project* (new name for *tenant*), an authentication *domain* for 
this *project*, a *user*, an authentication *domain* for this *user* (the two 
domains can be different).
+
+JClouds provide backward compatibility between keystone v2-v3 ... but you 
should have following section in mind to fully understand the authentication on 
your Openstack platform (in addition of blog: [OpenStack Keystone V3 
Support](https://jclouds.apache.org/blog/2018/01/16/keystone-v3/)).

`provides` instead of `provide`

> +
+Openstack Keystone (aka: [OpenStack Identity 
Service](https://docs.openstack.org/keystone/latest/)) has major changes 
between v2 and v3 (detail. [Identity API v2.0 and v3 
History](https://docs.openstack.org/keystone/latest/contributor/http-api.html)).
+
+Basically to login, you should provide:
+
+* On v2: *tenant*, *user*, *password*.
+* On v3: a *project* (new name for *tenant*), an authentication *domain* for 
this *project*, a *user*, an authentication *domain* for this *user* (the two 
domains can be different).
+
+JClouds provide backward compatibility between keystone v2-v3 ... but you 
should have following section in mind to fully understand the authentication on 
your Openstack platform (in addition of blog: [OpenStack Keystone V3 
Support](https://jclouds.apache.org/blog/2018/01/16/keystone-v3/)).
+
+### v2
+
+This snippet:
+{% highlight java %}
+final Properties overrides = new Properties();
+overrides.put(KeystoneProperties.KEYSTONE_VERSION, "2");

isn't `KEYSTONE_VERSION=2` the default?

> +
+Basically to login, you should provide:
+
+* On v2: *tenant*, *user*, *password*.
+* On v3: a *project* (new name for *tenant*), an authentication *domain* for 
this *project*, a *user*, an authentication *domain* for this *user* (the two 
domains can be different).
+
+JClouds provide backward compatibility between keystone v2-v3 ... but you 
should have following section in mind to fully understand the authentication on 
your Openstack platform (in addition of blog: [OpenStack Keystone V3 
Support](https://jclouds.apache.org/blog/2018/01/16/keystone-v3/)).
+
+### v2
+
+This snippet:
+{% highlight java %}
+final Properties overrides = new Properties();
+overrides.put(KeystoneProperties.KEYSTONE_VERSION, "2");
+
+ContextBuilder.newBuilder(new SomeApiMetadata())

why `new SomeApiMetadata()`? wouldn't be clear with something as generic as 
`openstack-nova`

> +* On v3: a *project* (new name for *tenant*), an authentication *domain* for 
> this *project*, a *user*, an authentication *domain* for this *user* (the two 
> domains can be different).
+
+JClouds provide backward compatibility between keystone v2-v3 ... but you 
should have following section in mind to fully understand the authentication on 
your Openstack platform (in addition of blog: [OpenStack Keystone V3 
Support](https://jclouds.apache.org/blog/2018/01/16/keystone-v3/)).
+
+### v2
+
+This snippet:
+{% highlight java %}
+final Properties overrides = new Properties();
+overrides.put(KeystoneProperties.KEYSTONE_VERSION, "2");
+
+ContextBuilder.newBuilder(new SomeApiMetadata())
+   .endpoint("https://host:5000/v2.0";)
+   .credentials("myTenant:foo", "bar")
+   .overrides(overrides)
+   .buildApi(Some.class);

why `Some.class` here? I think `NovaApi.class` is a bit better, as it is now in 
http://jclouds.apache.org/guides/openstack/#nova, wdyt?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#pullrequestreview-117969130

Reply via email to