nacx commented on this pull request.
> @@ -52,15 +52,15 @@
@Consumes(MediaType.APPLICATION_JSON)
@RequestFilters(FormSign.class)
@QueryParams(keys = {"Version", "Format", "SignatureVersion", "ServiceCode",
"SignatureMethod"},
- values = {"2014-05-26", "JSON", "1.0", "ecs", "HMAC-SHA1"})
+ values = { ECSServiceApiMetadata.DEFAULT_API_VERSION, "JSON", "1.0",
"ecs", "HMAC-SHA1"})
Use `"{" + Constants.PROPERTY_API_VERSION + "}"` instead for the version, so
the value of the variable is used. This way instead of having a hardcoded
value, it will pick the default one, or the one configured by users at runtime
when creating the context via the `apiVersion` method.
> public interface ImageApi {
@Named("image:list")
@GET
@QueryParams(keys = "Action", values = "DescribeImages")
@ResponseParser(ParseImages.class)
@Fallback(Fallbacks.EmptyIterableWithMarkerOnNotFoundOr404.class)
- PaginatedCollection<Image> list(@QueryParam("RegionId") String region,
ListImagesOptions... options);
+ IterableWithMarker<Image> list(@QueryParam("RegionId") String region,
ListImagesOptions options);
It is OK to return PaginatedCollection
>
- String signature;
-
- Multimap<String, String> decodedParams =
queryParser().apply(request.getEndpoint().getRawQuery());
-
- SimpleDateFormat df = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'");
+ SimpleDateFormat df = new SimpleDateFormat(ECS_DATE_FORMAT);
Why not declare the `SimpleDateFormat` object as a constant?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438#pullrequestreview-134421615
