jglick commented on this pull request.


>  
 @Test(groups = "unit")
 public class Strings2Test {
 
    public void testReplaceTokens() {
       assertEquals(Strings2.replaceTokens("hello {where}", 
ImmutableMap.of("where", "world")), "hello world");
+      assertEquals(Strings2.replaceTokens("hello {where}", 
ImmutableMap.of("where", "$1,000,000 \\o/!")), "hello $1,000,000 \\o/!");

This already passed…

>  
 @Test(groups = "unit")
 public class Strings2Test {
 
    public void testReplaceTokens() {
       assertEquals(Strings2.replaceTokens("hello {where}", 
ImmutableMap.of("where", "world")), "hello world");
+      assertEquals(Strings2.replaceTokens("hello {where}", 
ImmutableMap.of("where", "$1,000,000 \\o/!")), "hello $1,000,000 \\o/!");
+      assertEquals(Strings2.replaceTokens("hello {where}", 
ImmutableMultimap.of("where", "$1,000,000 \\o/!")), "hello $1,000,000 \\o/!");

…but this threw an exception.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1228#pullrequestreview-135972918

Reply via email to