andreaturli commented on this pull request.
> @@ -290,6 +290,19 @@ private EC2HardwareBuilder hs1() {
virtualizationTypes(VirtualizationType.HVM,
VirtualizationType.PARAVIRTUAL);
return this;
}
+
+ private EC2HardwareBuilder x1() {
+ virtualizationTypes(VirtualizationType.HVM);
+
+ // TODO X1 is not deprecated, but it requires that you are using
a VPC
+ // until we have a way for hardware instances to be filtered
based on network
+ // we do NOT want X1 selected automatically.
+ // You get: org.jclouds.aws.AWSResponseException: request POST
https://ec2.eu-west-1.amazonaws.com/ HTTP/1.1 failed with code 400, error:
AWSError{requestId='2300b99e-ddc0-42ab-b1ed-9d628a161be4', requestToken='null',
code='VPCResourceNotSpecified', message='The specified instance type can only
be used in a VPC. A subnet ID or network interface ID is required to carry out
the request.', context='{Response=, Errors=}'}
+ // A user can explicitly request a x1 if they are also setting up
a VPC.
+ deprecated();
I think it makes sense. I'll merge it asap
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1235#discussion_r212389076
