ak58588 commented on this pull request.


> @@ -63,6 +64,17 @@ protected final String guiceProvideTimeStamp(@TimeStamp 
> Supplier<String> cache)
    protected String provideTimeStamp(@TimeStamp Supplier<String> cache) {
       return cache.get();
    }
+   
+   /** 
+   * checks which Authentication type is used 
+   *
+   */
+   @Named("sasAuth")
+   @Provides 
+   protected Boolean authSAS(@org.jclouds.location.Provider 
Supplier<Credentials> creds) {
+         String credential =  creds.get().credential;
+      return credential.matches("sv.*se.*sig.*");

yes, with this one `svsesig` the ones with se coming first won't work. 
I have thought of something like this: 
` boolean authSAS(Supplier<Credentials> creds) {
                String testSAS = creds.get().credential;
                String[] sasPieces = testSAS.split(testSAS);    
                String regex = 
"(sv=[0-9]{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1]))|(sr=(b|c))|(sp=[rwdlacup]{1,8})|(se=.{10,22})|(sig=.{45,55})|(sip=.*)|(spr=(https,http)|https)|(rscc.*)|(rscd.*)|(rsce.*)|(rscl.*)|(rsct.*)|(si=.*)|(api-version=.*)|(ss=[bqtf]{1,4})|(srt=[sco]{1,3}).*";
                
                for(String sasPiece : sasPieces) {
                        if(!sasPiece.matches(regex)) {
                                return false;
                        }
                }
                return true;
           }`


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1270#discussion_r256302705

Reply via email to