gaul commented on a change in pull request #23: draft - disable AccessPolicy
check for SAS Authorised azureblob
URL: https://github.com/apache/jclouds/pull/23#discussion_r279365982
##########
File path:
providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/functions/BlobPropertiesToBlobMetadata.java
##########
@@ -58,6 +59,8 @@ public MutableBlobMetadata apply(BlobProperties from) {
PublicAccess containerAcl =
containerAcls.getUnchecked(from.getContainer());
if (containerAcl != PublicAccess.PRIVATE)
to.setPublicUri(from.getUrl());
+ } catch (UncheckedExecutionException ue) {
+ to.setPublicUri(from.getUrl());
Review comment:
I agree with your comment! But I am suggesting that if the bucket is
non-public, it should not have a public URI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
