nacx commented on a change in pull request #27: JCLOUDS-1497: Fix checkstyle-suppressions for jcloud-labs URL: https://github.com/apache/jclouds/pull/27#discussion_r281929022
########## File path: resources/checkstyle.xml ########## @@ -48,7 +48,7 @@ </module> <module name="NoWhitespaceBefore"/> <module name="RedundantImport"/> - <module name="RedundantModifier"/> + <!-- <module name="RedundantModifier"/> --> Review comment: Right. I ran a local build and only in `core` there were more than 40 violations. I fixed them, then found the same in another project... So I agree the value this check provides is close to zero and I think removing it is OK. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services