demobox commented on a change in pull request #38: Add OSGi exports to
jclouds-gson
URL: https://github.com/apache/jclouds/pull/38#discussion_r296431923
##########
File path: gson/pom.xml
##########
@@ -26,56 +26,21 @@
<relativePath>../project/pom.xml</relativePath>
</parent>
- <!--
- JCLOUDS-1166: This project relocates the 'com.google.gson.internal' package
- so we can keep using its contents in OSGi environments.
- This is a temporal solution and we should try to remove the usages of the
classes in
- there and remove this once that is done.
- -->
- <artifactId>jclouds-gson</artifactId>
- <name>jclouds gson copy without internal packages</name>
- <packaging>bundle</packaging>
+ <artifactId>jclouds-gson-modules</artifactId>
Review comment:
[minor] Just curious what this aggregator POM does? I guess it's because we
didn't want two gson-related bundles at the top level (if so, definitely agree
that that)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
