gaul commented on a change in pull request #43: JCLOUDS-1511: allow configuration of S3 to use V4 signatures URL: https://github.com/apache/jclouds/pull/43#discussion_r319211152
########## File path: apis/s3/src/test/java/org/jclouds/s3/config/S3HttpApiModuleTest.java ########## @@ -0,0 +1,63 @@ +package org.jclouds.s3.config; + +import com.google.common.collect.ImmutableList; +import com.google.common.io.ByteSource; +import com.google.inject.AbstractModule; +import com.google.inject.Guice; +import com.google.inject.Module; +import com.google.inject.name.Names; +import org.jclouds.location.config.LocationModule; +import org.jclouds.logging.config.NullLoggingModule; +import org.jclouds.providers.JcloudsTestBlobStoreProviderMetadata; +import org.jclouds.providers.ProviderMetadata; +import org.jclouds.rest.config.CredentialStoreModule; +import org.jclouds.rest.internal.BaseRestApiTest; +import org.jclouds.s3.blobstore.config.S3BlobStoreContextModule; +import org.jclouds.s3.filters.RequestAuthorizeSignature; +import org.jclouds.s3.filters.RequestAuthorizeSignatureV2; +import org.jclouds.s3.filters.RequestAuthorizeSignatureV4; +import org.testng.annotations.Test; + +import java.util.List; +import java.util.concurrent.ConcurrentHashMap; + +import static org.jclouds.Constants.PROPERTY_SESSION_INTERVAL; +import static org.jclouds.s3.reference.S3Constants.PROPERTY_S3_V4_REQUEST_SIGNATURES; +import static org.testng.Assert.assertTrue; + +/** + * @author roded + */ Review comment: Please remove `@author` tag since this exists in git history. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
