timuralp commented on this pull request.


>  
       for (MultipartPart part : parts) {
          Blob blobPart = getBlob(mpu.containerName(), MULTIPART_PREFIX + 
mpu.id() + "-" + mpu.blobName() + "-" + part.partNumber());
          contentLength += 
blobPart.getMetadata().getContentMetadata().getContentLength();
          blobs.add(blobPart);
-         
md5Hasher.putBytes(BaseEncoding.base16().lowerCase().decode(blobPart.getMetadata().getETag()));
+         if (blobPart.getMetadata().getETag() != null) {
+            
md5Hasher.putBytes(BaseEncoding.base16().lowerCase().decode(blobPart.getMetadata().getETag()));

I did consider that and thought that previously the blob store returned the 
hash of the entire content on PUT. Looking back, it looks like it actually 
returned the hash of an empty string (as the blob part ETag didn't exist). I'll 
change this patch to the same behavior, keeping the `-{number of parts}` suffix 
for consistency.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1285#discussion_r388117257

Reply via email to