nacx commented on a change in pull request #75:
URL: https://github.com/apache/jclouds/pull/75#discussion_r440391534
##########
File path: project/pom.xml
##########
@@ -217,12 +217,12 @@
</developers>
<properties>
- <maven.compile.source>1.7</maven.compile.source>
- <maven.compile.target>1.7</maven.compile.target>
- <jdk.version>1.7</jdk.version>
+ <maven.compile.source>1.8</maven.compile.source>
+ <maven.compile.target>1.8</maven.compile.target>
+ <jdk.version>1.8</jdk.version>
<maven.compile.deprecation>true</maven.compile.deprecation>
<maven.site.url.base>gitsite:[email protected]/jclouds/jclouds-maven-site.git</maven.site.url.base>
- <guava.version>18.0</guava.version>
+ <guava.version>22.0</guava.version>
Review comment:
Agree.
##########
File path:
apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java
##########
@@ -57,9 +57,7 @@ public void handleError(HttpCommand command, HttpResponse
response) {
exception = new AuthorizationException(message, exception);
break;
case 404:
- if (!command.getCurrentRequest().getMethod().equals("DELETE")) {
- exception = new ResourceNotFoundException(message,
exception);
- }
+ exception = new ResourceNotFoundException(message, exception);
Review comment:
This is a common pattern in jclouds APIs: if you attempt to delete a
resource that does not exist, do not fail the operation because you're already
in the desired state.
Why does this need to be changed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
