gaul commented on a change in pull request #92: URL: https://github.com/apache/jclouds/pull/92#discussion_r542413306
########## File path: core/src/main/java/org/jclouds/proxy/ProxyExcludePatterns.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.jclouds.proxy; + +import com.google.common.base.Function; +import com.google.common.base.Predicate; +import com.google.common.collect.ImmutableSet; +import org.jclouds.logging.Logger; + +import javax.annotation.Resource; +import javax.inject.Inject; +import java.util.Collections; +import java.util.Map; +import java.util.Set; +import java.util.regex.Pattern; +import java.util.regex.PatternSyntaxException; + +import static org.jclouds.Constants.PROPERTY_PROXY_EXCLUDE_URI_PATTERN_PREFIX; +import static org.jclouds.util.Predicates2.startsWith; + +/** + * Proxy URI pattern excludes. + */ +public class ProxyExcludePatterns { + + @Resource + protected Logger logger = Logger.NULL; + + private final Set<Pattern> excludeUrisPatterns; + + @Inject + ProxyExcludePatterns(Function<Predicate<String>, Map<String, String>> filterStringsBoundByName) { Review comment: This seems like special case behavior that other users are unlikely to discover. Instead of modifying `ProxyForURI`, could you override `RestModule.configure` in your application? ########## File path: core/src/main/java/org/jclouds/Constants.java ########## @@ -182,6 +182,11 @@ */ public static final String PROPERTY_PROXY_FOR_SOCKETS = "jclouds.proxy-for-sockets"; + /** + * List of URI patterns for which the defined proxy will not be used. + */ + public static final String PROPERTY_PROXY_EXCLUDE_URI_PATTERN_PREFIX = "jclouds.proxy-exclude-uri-pattern."; Review comment: What is the format of this? If it's a list, is it comma-seperated? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
