gurkerl83 edited a comment on pull request #86: URL: https://github.com/apache/jclouds/pull/86#issuecomment-770378779
@gaul, thanks for some feedback, about Guice, the current version in master is 4.2.3; previous to this version, Guice 3.0 was used. Guice 3.0 did not use guava as a dependency; this was introduced in guava 4 https://mvnrepository.com/artifact/com.google.inject/guice/3.0 https://mvnrepository.com/artifact/com.google.inject/guice/4.0 Using a Guice version closer to 4 like 4.1 does not set the boundary of guava to high (guava 19 required) but provides the risk of losing significant improvements made in Guice during 2016 - 2020, which is think is more critical. > Before this PR, jclouds supported Guava 22-30 This was an estimation, maybe by experiment rather than looking at the possible version ranges in general. Guice 3.0 was used previously; the guava version range was probably meant for a different problem and was not related to Guice. In my opinion, it is acceptable to set some minor requirements a delegate those to the consumer. When you keep this forever, no progress is going to be made. > Also, the last message for okio confuses me: ... The version appears to be the same? They are the same. I wrote this comment taking into account forthcoming changes that might get introduced by https://github.com/apache/jclouds/pull/84. Because of no recent activity about this branch's final state, it is unlikely to be considered for a release. > 2.3.0 upgrades a bunch of other dependencies, including requiring Java 8, so I think bumping a few more will be OK. What dependencies have you in mind, more like dev dependencies used for the build or those in the code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org