jiffysrc commented on a change in pull request #125:
URL: https://github.com/apache/jclouds/pull/125#discussion_r775462999
##########
File path: apis/s3/src/main/java/org/jclouds/s3/S3Client.java
##########
@@ -640,6 +651,30 @@ void enableBucketLogging(@Bucket @EndpointParam(parser =
AssignCorrectHostnameFo
void disableBucketLogging(@Bucket @EndpointParam(parser =
AssignCorrectHostnameForBucket.class) @BinderParam(
BindNoBucketLoggingToXmlPayload.class)
@ParamValidators(BucketNameValidator.class) String bucketName);
+ @Named("GetBucketConfiguration")
+ @GET
+ @Path("/")
+ @ResponseParser(BucketConfigurationHandler.class)
+ String getBucketConfiguration(@Bucket @EndpointParam(parser =
AssignCorrectHostnameForBucket.class) @BinderParam(
+ BindAsHostPrefixIfConfigured.class)
@ParamValidators(BucketNameValidator.class) String bucketName,
+ BucketConfigOptions... options);
+
+ @Named("DeleteBucketConfiguration")
+ @DELETE
+ @Path("/")
+ @ResponseParser(BucketConfigurationHandler.class)
+ String deleteBucketConfiguration(@Bucket @EndpointParam(parser =
AssignCorrectHostnameForBucket.class) @BinderParam(
+ BindAsHostPrefixIfConfigured.class)
@ParamValidators(BucketNameValidator.class) String bucketName,
BucketConfigOptions... options);
+
+ @Named("PutBucketConfiguration")
+ @PUT
+ @Path("/")
+ @ResponseParser(BucketConfigurationHandler.class)
+ String putBucketConfiguration(@Bucket @EndpointParam(parser =
AssignCorrectHostnameForBucket.class) @BinderParam(
Review comment:
Hi @gaul
Will be raising new PR for this change with unit tests, and other noise
changes highlighted in above comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
