gaul commented on code in PR #206:
URL: https://github.com/apache/jclouds/pull/206#discussion_r1679459404
##########
apis/s3/src/main/java/org/jclouds/s3/filters/AwsHostNameUtils.java:
##########
@@ -26,7 +26,7 @@
public class AwsHostNameUtils {
- private static final Pattern S3_ENDPOINT_PATTERN =
Pattern.compile("^(?:.+\\.)?s3[.-]([a-z0-9-]+)$");
+ private static final Pattern S3_ENDPOINT_PATTERN =
Pattern.compile("^(?:.+\\.)?s3[.\\-]([a-z0-9-]+)(?>\\.[a-z0-9-]+)*$");
Review Comment:
Can you add some kind of unit test which exercises this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
