yaooqinn commented on a change in pull request #2113:
URL: https://github.com/apache/incubator-kyuubi/pull/2113#discussion_r825559134
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala
##########
@@ -125,7 +144,17 @@ class ExecuteStatement(
setState(OperationState.CANCELED)
case TIMEDOUT_STATE =>
- setState(OperationState.TIMEOUT)
+ val state =
+ if (operationQueryTimeoutCompatibleState) {
+ if (queryTimeout > 0) {
Review comment:
do we need this?TIMEDOUT_STATE only happens when `queryTimeout>0` is
satisfied on the engine side.
this may be much simpler
case TIMEDOUT_STATE if operationQueryTimeoutCompatibleState =>
OperationState.CANCELED
case TIMEDOUT_STATE => OperationState.TIMEOUT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]