cxzl25 commented on code in PR #3792:
URL: https://github.com/apache/incubator-kyuubi/pull/3792#discussion_r1024946458
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineTab.scala:
##########
@@ -107,4 +122,10 @@ case class EngineTab(
engine.get.stop()
}
}
+
+ def handleGracefulKillRequest(request: HttpServletRequest): Unit = {
+ if (killEnabled && engine.isDefined && engine.get.getServiceState !=
ServiceState.STOPPED) {
+ engine.get.gracefulStop()
Review Comment:
Because the service can only be stopped once, when the service is in the
stop state, multiple clicks will not affect.
## Engine log
### First click
```
INFO EngineServiceDiscovery: Service[EngineServiceDiscovery] is stopped.
```
## Second click
```
WARN EngineServiceDiscovery: Service[EngineServiceDiscovery] is not
started(STOPPED) yet.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
